@W-16383704: Convert near-membrane's binary data tests to MaxPerf/MaxCompat #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwaldron
reviewed
Aug 2, 2024
manuel-jasso
changed the title
This is to be able to have real js files for testing in the sandbox
…even when maxCompatMode is false
Split the maxPerfModeKeys into intrinsics and browser, ok for now, to be improved
manuel-jasso
force-pushed
the
maxperf-initial-impl
branch
from
8ab59e7 to
bd85ff9
Compare
Also removed Husky's commit-msg
rwaldron
approved these changes
Aug 5, 2024
| ); | ||
| ], | ||
| // Ideally these should come from browser-realm, that's a code reorg improvement for later | ||
| browser: ['Blob', 'crypto', 'Crypto', 'File', 'FileReader', 'SubtleCrypto', 'URL'], |
There was a problem hiding this comment.
This works for me, and I agree with your comment 👍
| 'Int16Array', | ||
| 'Int32Array', | ||
| 'Int8Array', |
There was a problem hiding this comment.
Ugh... looks like the built in VSCode sort is strictly lexicographical 🤮
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
W-16383704: Convert near-membrane's binary data tests to MaxPerf/MaxCompat | Work